EP-3555 add missing processes for callbacks #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
soxofaan
force-pushed
the
EP3555-callbacks
branch
2 times, most recently
from
8edbef9
to
7a12005
Compare
jdries
reviewed
Sep 17, 2020
docs/processes.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| from openeo.processes.processes import absolute, max |
There was a problem hiding this comment.
Can we avoid the double 'processes'? For instance by importing everything from processes.py in the init.py?
There was a problem hiding this comment.
I will restructure code a bit to have imports like from openeo.processes import max
jdries
reviewed
Sep 17, 2020
openeo/processes/generator.py
Outdated
| from openeo.processes.parse import Process, parse_all_from_dir | ||
|
|
||
|
|
||
| class PythonRenderer: |
There was a problem hiding this comment.
Minor: this utility could be kept out of the source tree, to avoid packaging it in the wheel? Just to avoid confusing users.
There was a problem hiding this comment.
will move this to openeo.internal
jdries
requested changes
Sep 17, 2020
unify callback handling: - allow specifying as string, PGNode or Callable - de-boilerplate it in `apply_dimension`, `reduce_dimension`, `apply_neighborhood`, `apply`, `merge_cubes`, `aggregate_spatial`, `load_collection`
soxofaan
force-pushed
the
EP3555-callbacks
branch
from
7a12005
to
0fc03ab
Compare
|
pushed extra commit addressing the comments (restructuring files) |
|
both Jenkins and Travis are happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of EP-3521/#149: add missing processes for callbacks (EP-3555)
generator.pyto generate python source code that provides functions and methods corresponding to all processes from https://github.com/Open-EO/openeo-processes. (based on Process generation #112, which was still 0.4-style)DataCubemethods that support i:apply_dimension,reduce_dimension,apply_neighborhood,apply,merge_cubes,aggregate_spatial,load_collection