-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-3555 add missing processes for callbacks #153
Conversation
8edbef9
to
7a12005
Compare
docs/processes.rst
Outdated
|
||
.. code-block:: python | ||
|
||
from openeo.processes.processes import absolute, max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid the double 'processes'? For instance by importing everything from processes.py in the init.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will restructure code a bit to have imports like from openeo.processes import max
openeo/processes/generator.py
Outdated
from openeo.processes.parse import Process, parse_all_from_dir | ||
|
||
|
||
class PythonRenderer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: this utility could be kept out of the source tree, to avoid packaging it in the wheel? Just to avoid confusing users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will move this to openeo.internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, main comment is about the import of processes!
unify callback handling: - allow specifying as string, PGNode or Callable - de-boilerplate it in `apply_dimension`, `reduce_dimension`, `apply_neighborhood`, `apply`, `merge_cubes`, `aggregate_spatial`, `load_collection`
7a12005
to
0fc03ab
Compare
pushed extra commit addressing the comments (restructuring files) |
both Jenkins and Travis are happy |
Follow up of EP-3521/#149: add missing processes for callbacks (EP-3555)
generator.py
to generate python source code that provides functions and methods corresponding to all processes from https://github.com/Open-EO/openeo-processes. (based on Process generation #112, which was still 0.4-style)DataCube
methods that support i:apply_dimension
,reduce_dimension
,apply_neighborhood
,apply
,merge_cubes
,aggregate_spatial
,load_collection